Eagerly address select Rust 2024 edition changes #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Requires us to document safety within our own unsafe functions. See Rust RFC 2585 for more information. This warning promotes to an error in CI.
This becomes a hard error in the 2024 edition, so this commit is for future proofing. Safety comment indicates that there's only one mutable reference to this static that's live at a time.
teburd
approved these changes
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2024 edition enables
unsafe_op_in_unsafe_fnby default. This PR addsunsafeblocks and safety considerations throughout HAL and logging packages. There shouldn't be any functional changes.Today's stable toolchain (1.77) also warns about the explicit references to
static muts. I'm taking the simple approach to resolve this eventual hard error.Tested on an 1170EVK using the
rtic_loggingexample, with both backends and both frontends.